Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to load files and routes at run time. #74

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Allow to load files and routes at run time. #74

wants to merge 7 commits into from

Conversation

Criptos
Copy link

@Criptos Criptos commented Sep 16, 2013

I'm using Epiphan for a fairly big project, so, needing to load all the application and classes in one single point, makes the code to complex and the load to heavy, so to break down the loading I create a lazyload so when you detect a route, you load a file where you can have more definitions and code loaded, this way I can manage a fairly good integration and delegation, and avoid to many routes in a single file.

@challgren
Copy link

In EpiRoute.php you have debug code at line 100
On Sep 16, 2013 1:28 AM, "Criptos" [email protected] wrote:

I'm using Epiphan for a fairly big project, so, needing to load all the
application and classes in one single point, makes the code to complex and
the load to heavy, so to break down the loading I create a lazyload so when
you detect a route, you load a file where you can have more definitions and
code loaded, this way I can manage a fairly good integration and

delegation, and avoid to many routes in a single file.

You can merge this Pull Request by running

git pull https://github.com/Criptos/epiphany master

Or view, comment on, or merge it at:

#74
Commit Summary

  • Added lazyRoute function to allow to segment the load of information
    based on routes
  • Added explanation to getRoute()->lazyLoad("path", "filename");
  • Document fix and code cleaning

File Changes

Patch Links:

@jmathai
Copy link
Owner

jmathai commented Sep 26, 2013

Is the use case for this to define a set of routes that belong to a blog as a lazy route of /blog* which loads the more specific routes?

How many routes are you loading now at which point it becomes too large?

@Criptos
Copy link
Author

Criptos commented Sep 26, 2013

El sep 26, 2013 5:00 PM, "Jaisen Mathai" [email protected]
escribió:

Is the use case for this to define a set of routes that belong to a blog
as a lazy route of /blog* which loads the more specific route

Yes...

How many routes are you loading now at which point it becomes too large?

At 50 it started to feel uncomfortable, when hit 100 it started to become a
mess... math was telling me we could get as far as 400+ routes and a lot of
mergin issues...

Splitting the load routes has simplified the development, produced less
merges and allowed more focus when delegating.


Reply to this email directly or view it on GitHub.

@jmathai
Copy link
Owner

jmathai commented Sep 26, 2013

@Criptos Thanks for the response. Just trying to wrap my head around this a bit more.

Is the benefit more to do with code management than performance, then?

@Criptos
Copy link
Author

Criptos commented Sep 26, 2013

Humm... i really didn't made speed measures... but memory usage was
lower... the aplication is quite big to really get a performance hit... we
are porting the application ifscore, www.ifscore.info check the gallery
links to get an idea... I even have a blog comparing several restful api..
and why I choose epi
El sep 26, 2013 5:21 PM, "Jaisen Mathai" [email protected]
escribió:

@Criptos https://github.com/Criptos Thanks for the response. Just
trying to wrap my head around this a bit more.

Is the benefit more to do with code management than performance, then?


Reply to this email directly or view it on GitHubhttps://github.com//pull/74#issuecomment-25208946
.

Criptos added 3 commits March 10, 2016 13:07
Added delete and end interfaces as declared by documentation.
Added function delete to unset variable of session, as documentation states
Fix warning when EpiSession::employ() only return 1 element.
@Criptos
Copy link
Author

Criptos commented Mar 13, 2019

Hello, new maintainer :) This still works, and I'm still around :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants