Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade for Rails 7.1 #203

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

simpl1g
Copy link

@simpl1g simpl1g commented Apr 18, 2024

I updated public/private keys, I'm not sure why they stopped working, maybe they expired. So I generated new with 50 years expiration.

@simpl1g
Copy link
Author

simpl1g commented May 8, 2024

@jmazzi Hi, sorry to bother you, any chances to review and release new version of gem? Tests are passing locally

@khrvi
Copy link

khrvi commented Jun 4, 2024

@jmazzi could you merge it if it looks good for you

@ByteDecoder
Copy link

@jmazzi please release the Rails 7.0.x gem version (right now only works with Rails 7 but not for 7.0.x) before this Rails 7.1 gem version

@johan-smits
Copy link
Contributor

This MR will support all 7.x versions. Is this desired that it will already support the upcoming Rails 7.2 release?

@simpl1g
Copy link
Author

simpl1g commented Jun 8, 2024

@johan-smits thanks, makes sense, downgraded dependency to exclude 7.2

@kayodeadeniyi
Copy link

@jmazzi Sorry for disturbing you, could you help review this PR? Thanks in advance.

@tkling
Copy link

tkling commented Sep 12, 2024

Bernie Sanders sitting in a foldable chair

@jmazzi bumping this now that it's idled for a few months 🙏 any chance you could review please?

@simpl1g
Copy link
Author

simpl1g commented Sep 16, 2024

Also prepared PR for Rails 7.2
simpl1g#2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants