better error checking

jmbarbone · Dec 6, 2024 · ba56c7a · ba56c7a
1 parent ac596b1
commit ba56c7a
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,6 +1,6 @@
 Package: Rprofile
 Title: Functions to be loaded with Rprofile
-Version: 0.0.0.9008
+Version: 0.0.0.9009
 Authors@R:
     person(given = "Jordan Mark",
            family = "Barbone",

diff --git a/R/check-cran-status.R b/R/check-cran-status.R
@@ -12,7 +12,7 @@
 
   if (is.null(email)) {
     email <- .try(get_description_emails())
-    if (inherits(email, "rprofile_error")) {
+    if (is_rprofile_error(email)) {
       return(invisible())
     }
   }
@@ -27,7 +27,7 @@
       cache = tempfile("dang_check_cran_status__", fileext = ".rds"),
       cache.life = 3600
     ))))
-    if (!inherits(res, "error")) {
+    if (!is_rprofile_error(res)) {
       show_table()
       success <- TRUE
     } else {

diff --git a/R/todos.R b/R/todos.R
@@ -59,7 +59,7 @@ do_todos <- function(
   if (
     !is.null(todo) &&
     !.quiet &&
-    !inherits(todo, "error")
+    !is_rprofile_error(todo)
   ) {
     print(todo)
   }

diff --git a/R/utils.R b/R/utils.R
@@ -45,3 +45,7 @@ yes_no <- function(..., na = NULL) {
 
   NA
 }
+
+is_rprofile_error <- function(x) {
+  inherits(x, "rprofile_error")
+}
-Original file line number
+Diff line change
@@ Expand Up / @@ -45,3 +45,7 @@ yes_no <- function(..., na = NULL) { @@
       NA
     }
+    is_rprofile_error <- function(x) {
+      inherits(x, "rprofile_error")
+    }