Upgrade to dotnet core 2.2 #73

milbrandt · 2019-07-06T12:43:12Z

see discussion in Issue #26

FsSonarRunner upgraded to self-contained dotnet Core 2.2 application. Build contains runners for

Windows x64 - tested with 1.2.204-ci
Linux x64
~~Os-X x 64~~

As I have only Windows build servers would be good if someone could also test Linux ~~or Os-X~~ environment.

Update: OX-X canceled after first Tests and to shrink jar.

milbrandt · 2019-07-06T13:22:03Z

FsSonarRunner/zip-assembly.xml

-        <include>*.exe</include>
-        <include>*.config</include>
-        <include>*/FSharp.Core.resources.dll</include>
+        <include>win-x86/**</include>


Plugin is now quiet large - about 100MB. That's because of 3 self-contained dotnet runners.
On out server the next largest is Cfamily-plugin with only 27MB.

Yes, this was my concern! most likely this will be a problem if uploading the plugin to marketplace. 100MB might also affect analysis times.

the alternative as I mentioned, would be to force users to have a dot net core runtime. What is your opinion?

also could be considerer to be create as a dotnet global tool.

Ex: dotnet tool install --global --add-source . OpenCoverPathConverter => https://github.com/jmecsoftware/OpenCover2SonarConverter/releases

Either require users to have dotnet core installed or have different budles depending on OS.

Now configured it as Framework-dependent executables (FDE). This includes all except the dotnet core runtime.

jar file is about 20MB for all 3 operating systems

appveyor.yml

FsSonarRunner/pom.xml

jmecosta · 2019-07-11T19:26:48Z

[22:25:12]
[Step 1/1] ERROR: Error during SonarQube Scanner execution
[22:25:12]
[Step 1/1] ERROR: java.io.IOException: Cannot run program "/opt/teamcity_1/work/eb0e872d80a5add3/.scannerwork/ProjectTools/linux-x86/FsSonarRunner": error=13, Permission denied
[22:25:12]
[Step 1/1] ERROR: Caused by: Cannot run program "/opt/teamcity_1/work/eb0e872d80a5add3/.scannerwork/ProjectTools/linux-x86/FsSonarRunner": error=13, Permission denied
[22:25:12]
[Step 1/1] ERROR: Caused by: error=13, Permission denied
[22:25:12]
[Step 1/1] ERROR:
[22:25:12]
[Step 1/1] ERROR: Re-run SonarQube Scanner using the -X switch to enable full debug logging.
[22:25:12]
[Step 1/1] [CxxSonarQubeMsbuidRunner] Failed analyze project, check log

Seems the FsSonarRunner is being packaged without execution permissions.

jmecosta · 2019-07-11T19:31:16Z

[22:30:57]
[Step 1/1] ERROR: java.io.IOException: Cannot run program "/buildAgent/work/eb0e872d80a5add3/.scannerwork/ProjectTools/osx-x86/FsSonarRunner": error=2, No such file or directory
[22:30:57]
[Step 1/1] ERROR: Caused by: Cannot run program "/buildAgent/work/eb0e872d80a5add3/.scannerwork/ProjectTools/osx-x86/FsSonarRunner": error=2, No such file or directory
[22:30:57]
[Step 1/1] ERROR: Caused by: error=2, No such file or directory

jmecosta

* Did you use the build from appveyor on your machines for sonar execution or your local build?

* In the log I can see the three dotnet-publish steps. Are the results available in `FsSonarRunner\FsSonarRunner\publish? In the log is unfortunately only Maven output, not the dotnet Output to console included.

yep, all 3 targets were created. But still it did fail

jmecosta · 2019-07-07T20:08:03Z

FsSonarRunner/zip-assembly.xml

-        <include>*.exe</include>
-        <include>*.config</include>
-        <include>*/FSharp.Core.resources.dll</include>
+        <include>win-x86/**</include>


Yes, this was my concern! most likely this will be a problem if uploading the plugin to marketplace. 100MB might also affect analysis times.

the alternative as I mentioned, would be to force users to have a dot net core runtime. What is your opinion?

FsSonarRunner/pom.xml

appveyor.yml

jmecosta · 2019-07-07T20:13:16Z

FsSonarRunner/zip-assembly.xml

-        <include>*.exe</include>
-        <include>*.config</include>
-        <include>*/FSharp.Core.resources.dll</include>
+        <include>win-x86/**</include>


also could be considerer to be create as a dotnet global tool.

Ex: dotnet tool install --global --add-source . OpenCoverPathConverter => https://github.com/jmecsoftware/OpenCover2SonarConverter/releases

This reverts commit e73a22e.

milbrandt · 2019-07-13T15:56:27Z

Wouldn't "to be create as a dotnet global tool" also require an Installation on the build server of dotnet Core? I'm reluctant as I just failed with FDE deployment - where only .NET Core 2.1 was installed.

milbrandt · 2019-07-13T15:57:37Z

f you can figure out Linux and/or OS-X issues just push in this PR.

dotnet/cli#6286

Tried to set executable flag from Java. Can you please test if this works?

jmecosta · 2019-07-15T19:00:46Z

Wouldn't "to be create as a dotnet global tool" also require an Installation on the build server of dotnet Core? I'm reluctant as I just failed with FDE deployment - where only .NET Core 2.1 was installed.

yeah your are right! so lets get the flags working

jmecosta · 2019-07-15T19:26:43Z

f you can figure out Linux and/or OS-X issues just push in this PR.
dotnet/cli#6286

Tried to set executable flag from Java. Can you please test if this works?

works now, however the hack https://github.com/jmecsoftware/sonar-fsharp-plugin/blob/8025038c0431444e4311eca378f0da512e4b6da7/FsSonarRunner/FsSonarRunner/Program.fs#L70 that ive made now is cutting one extra /, so it can find any file. Do u know how to pass absolute path from java side directly? the hack was done originally because i was not able to find a way to pass absolute path from java side since they change quite a bit the api.

# Conflicts: # README.md # appveyor.yml # sonar-communityfsharp-plugin/src/main/java/org/sonar/plugins/fsharp/FSharpSensor.java # sonar-communityfsharp-plugin/src/main/java/org/sonar/plugins/fsharp/utils/OSInfo.java

milbrandt · 2019-07-16T19:33:32Z

works now, however the hack
sonar-fsharp-plugin/FsSonarRunner/FsSonarRunner/Program.fs
     Line 70
       |> Seq.iter (fun file -> handleFileToAnalyse(file.Replace("file:///", ""))) 
that ive made now is cutting one extra /, so it can find any file. Do u know how to pass absolute path from java side directly? the hack was done originally because i was not able to find a way to pass absolute path from java side since they change quite a bit the api.

SonarQube gves the hint, it might be not an file URI. But otherwise, a not so elegant solution would be

      Paths.get(file.uri()).toAbsolutePath()

Update: As this is Independent of this PR I'll make a small separate PR #77 for this.

comment on PR #73 to URI hack

jmecosta · 2019-07-18T17:44:33Z

i still do a quick test, see if everything works in linuyx and osx

jmecosta · 2019-07-18T18:54:54Z

Linux ok

OSx nok,
[21:50:28]
[Step 1/1] ERROR: Error during SonarQube Scanner execution
[21:50:28]
[Step 1/1] ERROR: java.io.IOException: Cannot run program "/buildAgent/work/eb0e872d80a5add3/.scannerwork/ProjectTools/osx-x86/FsSonarRunner": error=13, Permission denied
[21:50:28]
[Step 1/1] ERROR: Caused by: Cannot run program "/buildAgent/work/eb0e872d80a5add3/.scannerwork/ProjectTools/osx-x86/FsSonarRunner": error=13, Permission denied
[21:50:28]
[Step 1/1] ERROR: Caused by: error=13, Permission denied

Supose we could for now just release windows and linux suport, leave OSx for another time

milbrandt · 2019-07-18T19:01:59Z

Linux ok
OSx nok,
...
[Step 1/1] ERROR: Caused by: error=13, Permission denied
Supose we could for now just release windows and linux suport, leave OSx for another time

I'll go and evaluate if changing permissions was successful. For me it's ok to remove OS-X, the jar will get smaller. But we should then do a quick retest on the systems again.

jmecosta · 2019-07-19T06:12:36Z

linux ok
osx nok

milbrandt · 2019-07-19T16:47:35Z

@jmecosta Did you close this PR by intend without merging?

milbrandt · 2019-07-20T06:08:03Z

As proposed I removed Thursday evening OS-X from the build (which shrunk the jar).

As I never ever worked with Apple products: Can we build self-contained .NET Core for OS-X on Windows? As far as I remember it was not possible for Xamarin.
Other .NET Core builds are working on your OS-X? The requirements are satisfied, especially OpenSSL installed?

jmecosta · 2019-07-21T17:07:31Z

Not sure what happen, was supose to be an approve

milbrandt · 2019-07-22T20:44:17Z

Not sure what happen, was supose to be an approve

Seems like current build 248 is running for me on windows. If you can approve it for Linux, it's good. On OS-X the build should still work. I saw there is some possibility to add an warning when an analysis was not executed, maybe we can include something like that in the furture. Personally I would like to merge this first.

jmecosta · 2019-07-23T06:07:35Z

Go ahead then. All ok for me

milbrandt self-assigned this Jul 6, 2019

milbrandt added this to the Update to dotnet Core milestone Jul 6, 2019

milbrandt requested a review from jmecosta July 6, 2019 12:43

milbrandt commented Jul 6, 2019

View reviewed changes

appveyor.yml Outdated Show resolved Hide resolved

milbrandt commented Jul 6, 2019

View reviewed changes

FsSonarRunner/pom.xml Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

milbrandt added 4 commits July 7, 2019 22:19

initial dotnet Core solution

ffa27c7

set version depending on branch

cc1be90

multi-targeting, self-contained FsSonarRunner

3a0fa78

docu + logging

ff69c5e

milbrandt force-pushed the feature/dotnetCore branch from b2fdd08 to ff69c5e Compare July 7, 2019 20:23

Update Reade.md - no longer mono

fb68829

This comment has been minimized.

Sign in to view

jmecosta reviewed Jul 11, 2019

View reviewed changes

This comment has been minimized.

Sign in to view

now framework dependend executeable, no longer self-contained

e73a22e

milbrandt added 2 commits July 13, 2019 17:40

Revert "now framework dependend executeable, no longer self-contained"

c1593d8

This reverts commit e73a22e.

PR feedback, set executeable

fbc258a

milbrandt added 2 commits July 15, 2019 22:32

Merge branch 'master' into feature/dotnetCore

cca7348

# Conflicts: # README.md # appveyor.yml # sonar-communityfsharp-plugin/src/main/java/org/sonar/plugins/fsharp/FSharpSensor.java # sonar-communityfsharp-plugin/src/main/java/org/sonar/plugins/fsharp/utils/OSInfo.java

sonar smell (test only method)

1d95af0

sonar issues

496824a

milbrandt added a commit that referenced this pull request Jul 16, 2019

Replace URI with absolute path for files to analyze

ace6120

comment on PR #73 to URI hack

milbrandt mentioned this pull request Jul 16, 2019

Replace URI with absolute path for files to analyze #77

Merged

milbrandt added 3 commits July 18, 2019 21:10

Merge branch 'master' into feature/dotnetCore

5365f60

remove OS-X, catch exception and log

6bfe753

sonar messages

f28ba54

jmecosta closed this Jul 19, 2019

jmecosta reopened this Jul 21, 2019

update test assert

84fe20b

milbrandt merged commit 1f58a4c into master Jul 23, 2019

milbrandt deleted the feature/dotnetCore branch August 3, 2019 10:25

Upgrade to dotnet core 2.2 #73

Upgrade to dotnet core 2.2 #73

Conversation

milbrandt commented Jul 6, 2019 • edited by jmecosta Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

jmecosta commented Jul 11, 2019

jmecosta commented Jul 11, 2019

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

jmecosta left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

milbrandt commented Jul 13, 2019 • edited Loading

milbrandt commented Jul 13, 2019

jmecosta commented Jul 15, 2019

jmecosta commented Jul 15, 2019

milbrandt commented Jul 16, 2019 • edited Loading

jmecosta commented Jul 18, 2019

jmecosta commented Jul 18, 2019

milbrandt commented Jul 18, 2019

jmecosta commented Jul 19, 2019

milbrandt commented Jul 19, 2019

milbrandt commented Jul 20, 2019 • edited Loading

jmecosta commented Jul 21, 2019

milbrandt commented Jul 22, 2019

jmecosta commented Jul 23, 2019

milbrandt commented Jul 6, 2019 •

edited by jmecosta

Loading

milbrandt commented Jul 13, 2019 •

edited

Loading

milbrandt commented Jul 16, 2019 •

edited

Loading

milbrandt commented Jul 20, 2019 •

edited

Loading