Fix CDN calculation #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Roblox added a 180DAY- prefix to hashes and this change accounts for that which brings the hash length up to 38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
180DAY-prefix to hashes and this change accounts for that which brings the hash length up to 38.Note that the
180DAY-prefix is for thumbnail 3D hashes only, other hashes have different prefixes but I made the case of that one because the hashes page makes the example with thumbnail-3d.I don't understand why it says that only the first X chars are used in the calculation when in reality you need to use the whole hash including prefixes.