Fixed #1428, an issue with preview the (empty) project placeholder. #1429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lder. The code treats this placeholder the same as any other proejct and attempts to open it, leading to a parse error.
jmoenig
reviewed
Sep 26, 2016
| myself.preview.cachedTexture = null; | ||
| myself.preview.drawNew(); | ||
|
|
||
| if (src) { |
|
Thanks for this fix, Thomas! I'll pull it and integrate it into the next release, but since I'm both travelling and probably switching day-jobs at the moment this might take me some days or even weeks. I've marked this PR with my "blessing" so I'll bulk-pull all before the next release gets out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick fix for #1428. The current code treats the "(empty)" placeholder the same as any other project and attempts to open it, leading to a parse error. This checks first and does nothing for invalid projects.