Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal for WorldMap library #2410

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

jguille2
Copy link
Contributor

@jguille2 jguille2 commented Jun 9, 2019

After fixing some issues on the WorldMap library, I want to propose some changes:

  • The World Map is always there virtually (with its location, zoom and style). Now that is the case. So, the new "main" blocks are show and hide to use this feature over the stage. We still have the "map as costume" to use it wherever you want.
  • And now, I can manage this virtual map (changing location, zoom, style... moving it, going to current location...) without forcing its visualization. If the map is visible, it will be updated. And if the map is hidden, the virtual map will be updated, but it will be not displayed (yet)
  • If I hide WorldMap, the stage will be take its last costume (what it had before the map). So, that "lastCostume" is stored inside the worldMap object. We can continue using the virtual map (doing calculations, modifying parametres...) and re-viewing whenever we want.
  • Longitude and Latitude are now shown always in the same order (lon-lat). This is for input slots, lists and also for the order inside the palette. This order has been chosen for its relation with x and y coordinates.
  • "change Map by x: and y: pixels" has been fixed to have the same behavior over x and y coordinates.
  • All the blocks (current and new) are translated to Deutsch and Catalan

Then, this proposal is:
MapBlocksProposal

If you want to test it...

Joan

@jguille2
Copy link
Contributor Author

jguille2 commented Jun 9, 2019

Only a last change.
"change Map by x: and y: pixels" is changed for "move" because it seems to be clear (we are moving the map)
So the last library block will be
moveMap
and someone will have to verify if the German translation is fine
moveMapDeutsch

That's all. Thanks!

Joan

@jguille2
Copy link
Contributor Author

Hi!
I only upload xml library file, to be able to try it more easily.
maps_module.xml.zip

@jguille2
Copy link
Contributor Author

Or even more easily here

Joan

@brianharvey
Copy link
Collaborator

I like this. Especially show/hide/shown.

While we're renaming things, I keep thinking "current location" means the location of the current sprite; what if we change "current" to "user's"?

In the "distance in km to" block, "Stage" in the menu is useless, but it would be useful to change that option to "Origin" or "Map Center."

"Move" is better than "change," but it's still not obvious what moves relative to what. Can we get one of those fist icons you see in map software when you're dragging the mouse on the map? It would go before "move."

@jguille2
Copy link
Contributor Author

Hi Brian,
I try to update it with your proposals. So...

  • current location to user location
    Then, the renamed blocks are
    userLocation1
    Jens will have to check my "german attempts" :)
    userLocation2
    I try to use emojis with the "gps-location" icon
    location-pointer2
    but I think there is no any good emoji to this.

  • distance in km block. I have not changed the menus (I can't without adding another custom menu) but I have changed their behavior. Now "Stage" is the "center of the map". So, "distance from sprite to stage" is the distance of that sprite to the center of the map. No more "-1" results.

  • Emoji for the "move map" block. Not easy! Your proposal (fist icon) is not an emoji (oncoming fist and raised fist is not appropriate). I want this other
    draggingIcon2
    but it is not either an emoji.
    It's not perfect... but I use this other to follow your idea...
    moveMap

Continue... You can test again with the updated project

Joan

@brianharvey
Copy link
Collaborator

I found "back of hand" 🤚U+1F91A, UTF-8 F0 9F A4...

It's really quite astonishing that this isn't in the "technical symbols" section of Unicode!

@jguille2
Copy link
Contributor Author

Then, it was
moveMap2
I await your decisions to commit this change.

Are the other changes right for you?

@brianharvey
Copy link
Collaborator

Fine with me. Jens?

@jmoenig
Copy link
Owner

jmoenig commented Jun 11, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants