Add support for cip 66 transactions #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO fetch converstion rates
…ND in token 120599798721937636601n. (cut off the zeros thats 11 and 12 -- a ratio that makes sense) remove .tests from jest command. now you can added in the file name after yarn test to only run specific test.
Closed
aaronmgdr
commented
Jun 5, 2024
| @@ -17,7 +17,7 @@ | |||
| "build": "yarn build:main && yarn build:module", | |||
| "build:main": "tsc -p tsconfig.json", | |||
| "build:module": "tsc -p tsconfig.module.json", | |||
| "test": "jest ./tests" | |||
| "test": "jest" | |||
There was a problem hiding this comment.
not needed and means that calling yarn test does not work
jmrossy
reviewed
Jun 5, 2024
src/lib/CeloProvider.ts
Outdated
| async getFeeData(feeCurrency?: string): Promise<FeeData> { | ||
| if (!feeCurrency) { | ||
| // for eip1559 and cip66 transactions are denominated in CELO, cip64 fees must be looked up in the fee token | ||
| async getFeeData(feeCurrency?: string, denominateInCelo?: boolean): Promise<FeeData> { |
There was a problem hiding this comment.
What purpose does this new param serve? When would denominate be true but fee currency would be truthy?
There was a problem hiding this comment.
because with this new transaction type feeCurrency exists but intead of maxFeePerGas and maxPriorityFeePerGas needing be looked up in that in the price for that token they are instead priced in CELO.
tests/CeloWallet.test.ts
Outdated
Comment on lines
31
to
32
|
|
||
|
|
There was a problem hiding this comment.
I know I'm nitpicking but can we run prettier and/or set it up in this repo?
There was a problem hiding this comment.
ran prettier on the changed files.
jmrossy
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Adding support for the CIP66 Transaction Type This upcoming transaction type will be supported on CEL2.
Defaults to using cip 66 if sending feeCurrency Transaction on a chain that supports it.CIP-66 support #22
add support for automatically calculating fee fields needed for cip66
add isCel2 helper which can be used by anyone to determine if chain is an OP based Layer 2 or still old Layer 1
bump type
minor; adds new features
other
separate transaction tests that dont use the network / need constant results into new unit tests file.
remove ./tests from the
testcommand. this added nothing and prevented adhoc filters being applied to which tests were ran likeyarn test CeloWallet