Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sort by play count #1087

Merged
merged 2 commits into from
Mar 11, 2025
Merged

sort by play count #1087

merged 2 commits into from
Mar 11, 2025

Conversation

Decimate1405
Copy link

@Chaphasilor
Copy link
Collaborator

I somehow missed this, but looking at it now :)

I think while Jellyfin offers a play count for things like albums and playlists, it never really gets updated, especially not when listening via Finamp. So this probably only really works for sorting tracks...

@Chaphasilor
Copy link
Collaborator

Chaphasilor commented Mar 8, 2025

Can you check if any of your albums or playlists have a play count other than 0? Otherwise I can merge this in but add a note to the release notes. Or we could only show the sort option for tracks.

@Decimate1405
Copy link
Author

It only works for tracks, I didn't really see an option that shows playlist/album counts, if this is something that's already implemented I can dig into it more but atm it'd only for tracks (verified this)

@Decimate1405
Copy link
Author

Decimate1405 commented Mar 8, 2025

Also, looking at the feature request they did mention "tracks" so I'm guessing that's the scope of sorting by plays for now as jellyfin doesn't update the album/playlist plays

@Chaphasilor
Copy link
Collaborator

Okay, I've adjusted the SortByMenuButton to only show the playCount option for the tracks tab, that should avoid confusion :)

Playlist/album play counts are currently not shown, but theoretically the Jellyfin API returns play count data in the UserData section of their BaseItemDtos. But it seems like Jellyfin never actually updates the play count, to it's effectively useless for now.

Thanks for the PR!

@Chaphasilor Chaphasilor merged commit 28455e0 into jmshrv:redesign Mar 11, 2025
4 checks passed
@Decimate1405 Decimate1405 deleted the sort_by_plays branch March 11, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants