Ensure the the hostname -> ip-address DNS resolution is done every time a socket is created #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me a socket is created. Add support for socket connectTimeout configuration with a default value of 500ms. Fix #55.
cyrille-leclerc
added a commit
that referenced
this pull request
Jun 22, 2013
Ensure the the hostname -> ip-address DNS resolution is done every time a socket is created
|
jmxtrans project » embedded-jmxtrans #69 SUCCESS |
ghost
assigned 
|
looks good to me - thanks! |
|
Hi Justin, I forgot to mention that this fix will properly recreate the socket doing a new DNS resolution but doe not add Time To Live support. I created #58 to track this non-trivial enhancement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.