feat: use k8s snap in dev preset #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnsgruk
force-pushed
the
k8s-in-dev
branch
2 times, most recently
from
d6614ec to
4a7fdf9
Compare
|
Converting to draft while investigating a potential bug in the removal of the k8s snap. |
jnsgruk
force-pushed
the
k8s-in-dev
branch
2 times, most recently
from
ec8f146 to
86d62a8
Compare
jnsgruk
force-pushed
the
k8s-in-dev
branch
2 times, most recently
from
cb0db82 to
9aeae48
Compare
jnsgruk
force-pushed
the
k8s-in-dev
branch
7 times, most recently
from
2bf3f44 to
39073c7
Compare
jnsgruk
force-pushed
the
k8s-in-dev
branch
2 times, most recently
from
fff71f8 to
e53a01f
Compare
On machines where containerd is already present the k8s snap can fail to bootstrap due to a conflict in the path. Github Actions runners ship with containerd by default, and they account for a large percentage of the machines where concierge will be run. As a result, this change will configure that base path to an alternate path to avoid the clash.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the K8s snap by default in the
devpreset.