chore: small perf improvement using useCallback

joamag · Aug 27, 2024 · a6e5b7f · a6e5b7f
1 parent 65815c2
commit a6e5b7f
Showing 1 changed file with 31 additions and 20 deletions.
diff --git a/frontends/web/react/components/debug/debug.tsx b/frontends/web/react/components/debug/debug.tsx
@@ -1,4 +1,4 @@
-import React, { FC, useEffect, useState } from "react";
+import React, { FC, useCallback, useEffect, useState } from "react";
 import { ButtonSwitch, Info, Pair } from "emukit";
 import { AudioGB } from "../audio-gb/audio-gb";
 import { RegistersGB } from "../registers-gb/registers-gb";
@@ -92,25 +92,36 @@ const DebugSettingsContent: FC<EmulatorProps> = ({ emulator }) => {
         };
     }, [emulator]);
 
-    const onPpuChange = (option: string) => {
-        emulator.instance?.set_ppu_enabled(option === "on");
-    };
-
-    const onApuChange = (option: string) => {
-        emulator.instance?.set_apu_enabled(option === "on");
-    };
-
-    const onDmaChange = (option: string) => {
-        emulator.instance?.set_dma_enabled(option === "on");
-    };
-
-    const onTimerChange = (option: string) => {
-        emulator.instance?.set_timer_enabled(option === "on");
-    };
-
-    const onSerialChange = (option: string) => {
-        emulator.instance?.set_serial_enabled(option === "on");
-    };
+    const onPpuChange = useCallback(
+        (option: string) => {
+            emulator.instance?.set_ppu_enabled(option === "on");
+        },
+        [emulator]
+    );
+    const onApuChange = useCallback(
+        (option: string) => {
+            emulator.instance?.set_apu_enabled(option === "on");
+        },
+        [emulator]
+    );
+    const onDmaChange = useCallback(
+        (option: string) => {
+            emulator.instance?.set_dma_enabled(option === "on");
+        },
+        [emulator]
+    );
+    const onTimerChange = useCallback(
+        (option: string) => {
+            emulator.instance?.set_timer_enabled(option === "on");
+        },
+        [emulator]
+    );
+    const onSerialChange = useCallback(
+        (option: string) => {
+            emulator.instance?.set_serial_enabled(option === "on");
+        },
+        [emulator]
+    );
 
     return (
         <Info key={updated}>