fix: multiple .net versions issue fixed #169
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Description
The original issue was related to handling many projects with different .NET versions. The
dotnet
command searches for test DLLs in subfolders defined in a test project. However, if the test is run for a solution with the--no-build
flag, the search subfolder might be incorrect. This leads to an error even for a DLLs with all tests passed (net8 subfolder is wrong):This results in an exit code
1
, even if after a rerun all tests were run successfully.The fix involves removing the addition of the framework version to the filter in the case of a test rerun. However, this fix has a slight disadvantage. If the same test supports multiple .NET versions, with the fix, all versions of the test will run. The differences are visible in the
DotnetTestRerun_FailingXUnit_WithMultipleFrameworks_Fails
test. This is a drawback, but I still find the result better. Running all configurations of a failing test instead of just one may not be necessary, but not fixing the issue makes the tool unusable in the above-defined case.Changes in the codebase
No
Associated Issues
#165