Use lexical-binding in yasnippet.el #1053
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emacs can optimize files that use lexical-binding slightly better, so this is a good thing to do. Additionally I've been experimenting with Andrea Corallo's
feature/native-comp
branch in upstream Emacs, and it can only native compile elisp files that use lexical-bidning, which is how I noticed that yasnippet.el did not.The tests pass in this branch and I don't get any warnings when byte-compiling (or native compiling) the file with lexical-binding, so it seems like a safe change to make.
I agree to copyright assignment of this change as described in the contributing guidelines.