Support using regexp for keys #1066
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously either of the directives "binding" or "key" had to be present in a snippet for it to load properly. If both are absent the resulting template gets the file name as a key. With this change "regexp-key" also has that status.
Different regexp keys could match the same text(say "[a-z]" and "[a-c]") while normal keys cannot(I think). This means that an ordering or priority between snippets become meaningful. For the above example it would not be clear which key would match the text "abc". If however, "[a-c]" has higher priority than "[a-z]" there would be only one choice: "[a-c]" would match.
|
Any updates on this ? |
|
Thank you for your quick reply, and I am sorry to disturb you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #988
I'm not sure if the commit messages or the code looks good so I'll mark this as a draft. I have signed the copyright-papers so that should not be an issue.