Prevent infinite recursion when displaying a warning. #1089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the *Warnings* buffer has auto-fill enabled and we're about to print the warning, `display-warning' would loop back here through `newline' and `self-insert-command', causing infinite recursion. I haven't been able to reproduce this in a noninteractive unit test, unfortunately, but the issue happens in interactive mode whenever `yas--original-auto-fill-function' is nil and `auto-fill-mode' is enabled in the *Warnings* buffer. * yasnippet.el (yas--auto-fill): Disable `auto-fill-mode' in the *Warnings* buffer as well.
What kind of let binding would you suggest? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the Warnings buffer has auto-fill enabled and we're about to print the
warning,
display-warning' would loop back here throughnewline' and`self-insert-command', causing infinite recursion.
I haven't been able to reproduce this in a noninteractive unit test,
unfortunately, but the issue happens in interactive mode whenever
yas--original-auto-fill-function' is nil andauto-fill-mode' is enabled inthe Warnings buffer.
buffer as well.