Fix non-compile error #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 4, 2019 18:16
…e there as the function modifies the reference parameter
knatten
suggested changes
Sep 27, 2019
| @@ -46,7 +46,7 @@ TEST_CASE("Basic usage") | |||
|
|
|||
| using NameRef = fluent::NamedType<std::string&, struct NameRefParameter>; | |||
|
|
|||
| void changeValue(const NameRef name) | |||
| void changeValue(NameRef name) | |||
There was a problem hiding this comment.
Nice that you fixed this compilation error!
| @@ -0,0 +1,4 @@ | |||
| cmake_minimum_required(VERSION 3.9) | |||
| project(NamedType) | |||
There was a problem hiding this comment.
Maybe change this to project(NamedType CXX) to indicate that it's a C++ project.
| @@ -0,0 +1,4 @@ | |||
| cmake_minimum_required(VERSION 3.9) | |||
There was a problem hiding this comment.
Any reason to require a cmake version this recent? Could be good to allow users on older cmake versions to use this as well.
There was a problem hiding this comment.
how about using 3.12? This is the version I use in the pipes library
|
This fixes #23 |
|
Could be an idea to split out the compilation error fix as a separate PR which will be a no-brainer to accept? |
|
see #37 |
|
This should be covered by PR #24 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added CMakeLists.txt for compilation with CMake and any IDE that supports CMake.
Removed const qualifier from function parameter where function modifiers parameter.