Merge pull request #19 from joelbarker2011/bug/agreement-exceptions

Raise Echosign errors for non-2xx responses

.rubocop_todo.yml

@@ -50,7 +50,7 @@ Lint/UselessAssignment:
 # Configuration parameters: CountComments, ExcludedMethods.
 # ExcludedMethods: refine
 Metrics/BlockLength:
-  Max: 123
+  Max: 128
 
 # Offense count: 3
 # Configuration parameters: CountComments, ExcludedMethods.
@@ -60,7 +60,7 @@ Metrics/MethodLength:
 # Offense count: 1
 # Configuration parameters: CountComments.
 Metrics/ModuleLength:
-  Max: 101
+  Max: 105
 
 # Offense count: 6
 # Configuration parameters: CountKeywordArgs.

lib/echosign/request.rb

@@ -130,10 +130,11 @@ def self.get(endpoint, headers)
         endpoint,
         headers: headers
       )
-      response
     rescue Exception => error
       raise_error(error)
     end
+
+    check_response(response)
   end
 
   def self.post(endpoint, body, headers, options = {})
@@ -146,20 +147,22 @@ def self.post(endpoint, body, headers, options = {})
         body = body.to_json if body.is_a?(Hash)
       end
       response = HTTParty.post(endpoint, body: body, headers: headers)
-      response
     rescue Exception => error
       raise_error(error)
     end
+
+    check_response(response)
   end
 
   def self.put(endpoint, query, headers)
     begin
       headers['Content-Type'] = 'application/json'
       response = HTTParty.put(endpoint, body: query, headers: headers)
-      response
     rescue Exception => error
       raise_error(error)
     end
+
+    check_response(response)
   end
 
   def self.add_query(url, query)
@@ -172,4 +175,9 @@ def self.raise_error(error)
       "https://secure.echosign.com/public/docs/restapi/v5"
     raise Failure.new message, error
   end
+
+  def self.check_response(response)
+    raise_error(response) unless response.success?
+    response
+  end
 end

spec/lib/agreement/client_spec.rb

@@ -45,6 +45,12 @@
         expect(agreement_id).to_not be_nil
       end
     end
+
+    it 'raises a specific exception on failure' do
+      VCR.use_cassette('create_agreement_failure', record: :once) do
+        expect { client.create_agreement(agreement) }.to raise_error(Echosign::Request::Failure)
+      end
+    end
   end
 
   describe '.get_agreements' do