[5.x] Bugfix redirect on OAuth Link Failed (#354)

* fix route not found

* Add a test

src/Http/Responses/OAuthProviderLinkFailedResponse.php

@@ -12,7 +12,7 @@ class OAuthProviderLinkFailedResponse implements OAuthProviderLinkFailedResponse
     public function toResponse($request): RedirectResponse
     {
         if (class_exists(Jetstream::class)) {
-            return redirect()->to('profile.show');
+            return redirect()->route('profile.show');
         }
 
         return Socialstream::redirects('provider-link-failed')

tests/Feature/SocialstreamTest.php

@@ -189,3 +189,54 @@ public function generate(string $provider): RedirectResponse
         'email' => '[email protected]',
     ]);
 });
+
+test('linking and already linked provider fails', function () {
+    // Arrange - existing user with account linked
+    $this->actingAs(User::create([
+        'name' => 'Joel Butcher',
+        'email' => '[email protected]',
+        'password' => Hash::make('password'),
+    ]));
+
+    $provider = mock(GithubProvider::class);
+    $provider->shouldReceive('user')->andReturn((new SocialiteUser())
+        ->map([
+            'id' => $githubId = fake()->numerify('########'),
+            'nickname' => 'joel',
+            'name' => 'Joel',
+            'email' => '[email protected]',
+            'avatar' => null,
+            'avatar_original' => null,
+        ])
+        ->setToken('user-token')
+        ->setRefreshToken('refresh-token')
+        ->setExpiresIn(3600));
+
+    Socialite::shouldReceive('driver')->with('github')->andReturn($provider);
+
+    get('http://localhost/oauth/github/callback');
+
+    $this->assertAuthenticated();
+    $this->assertDatabaseHas('connected_accounts', [
+        'provider' => 'github',
+        'provider_id' => $githubId,
+        'email' => '[email protected]',
+    ]);
+
+    // Arrange - new user
+    $this->actingAs(User::create([
+        'name' => 'Joel Butcher',
+        'email' => '[email protected]',
+        'password' => Hash::make('password'),
+    ]));
+
+    // Act
+    get('http://localhost/oauth/github/callback')
+        ->assertRedirectToRoute('profile.show')
+        ->assertSessionHas([
+            'flash' => [
+                'banner' => 'It looks like this GitHub account is used by another user. Please log in.',
+                'bannerStyle' => 'danger'
+            ]
+        ]);
+});