Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Fix PHP 8.4 deprecation warnings for implicit nullable types #376

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

selfsimilar
Copy link
Contributor

Resolve PHP 8.4 notices for deprecated 'Implicitly marking parameters as nullable'

Mostly annotating types as nullable by prepending a question mark.

Explanation

PHP 8.4 has a core deprecation of implicitly nullable parameter types. This PR resolves that issue.

Checklist

  • I've read this template
  • I've checked reviewed this PR myself, ensuring consistency and quality with the rest of the project
  • I've given a good reason as to why this PR exposes new / removes existing user data

@joelbutcher
Copy link
Owner

Adding a note that, whilst accepting of this change, we don't officially support PHP 8.4 yet

@joelbutcher joelbutcher changed the title Resolve PHP 8.4 notices for deprecated 'Implicitly marking parameters as nullable' [6.x] Fix PHP 8.4 deprecation warnings for implicit nullable types Sep 30, 2024
@joelbutcher joelbutcher merged commit d1c5cde into joelbutcher:6.x Sep 30, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants