Remove reference to setPreserveJsDocWhitespace #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`options.setPreserveJsDocWhitespace` is deprecated and removed. As-is, when built with the head compiler, this code throws: `1) Error in custom provider, java.lang.NoSuchMethodError: com.google.javascript.jscomp.CompilerOptions.setPreserveJsDocWhitespace(Z)V`. The new replacement option `setParseJsDocDocumentation` is called implicitly with the equivalent value in `setIdeMode`s implementation.
| @@ -78,7 +79,7 @@ CompilerOptions provideCompilerOptions( | |||
|
|
|||
| // IDE mode must be enabled or all of the jsdoc info will be stripped from the AST. | |||
| options.setIdeMode(true); | |||
There was a problem hiding this comment.
I'd guess that the rest of IDE mode isn't needed and can be removed. But you probably know what js-dossier needs better than I do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
options.setPreserveJsDocWhitespaceis deprecated and removed. As-is, when built with the head compiler, this code throws:1) Error in custom provider, java.lang.NoSuchMethodError: com.google.javascript.jscomp.CompilerOptions.setPreserveJsDocWhitespace(Z)V.The new replacement option
setParseJsDocDocumentationshould be called withConfig.JsDocParsing.INCLUDE_DESCRIPTIONS_WITH_WHITESPACE;