Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Parcel v2 #1

Closed
wants to merge 21 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,10 @@ jobs:
node-version: ${{ env.NODE_VERSION }}
cache: 'npm'
cache-dependency-path: '**/package-lock.json'
check-latest: true

- name: Install packages
run: npm ci
run: npm install

- name: Lint
run: npm run lint
Expand Down Expand Up @@ -78,11 +79,12 @@ jobs:
uses: actions/setup-node@v4
with:
node-version: ${{ env.NODE_VERSION }}
check-latest: true
cache: 'npm'
cache-dependency-path: '**/package-lock.json'

- name: Install packages
run: npm ci
run: npm install

- name: Set MacOS signing certs
if: matrix.os == 'macOS'
Expand Down Expand Up @@ -124,8 +126,8 @@ jobs:
APPLE_ID: ${{ secrets.APPLE_ID || '' }}
APPLE_ID_PASSWORD: ${{ secrets.APPLE_ID_PASSWORD || '' }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
# WINDOWS_CODESIGN_FILE: ${{ steps.write_file.outputs.filePath || '' }}
# WINDOWS_CODESIGN_PASSWORD: ${{ secrets.WINDOWS_CODESIGN_PASSWORD || '' }}
WINDOWS_CODESIGN_FILE: ${{ steps.write_file.outputs.filePath || '' }}
WINDOWS_CODESIGN_PASSWORD: ${{ secrets.WINDOWS_CODESIGN_PASSWORD || '' }}

- name: Release
uses: softprops/action-gh-release@v2
Expand Down
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -36,3 +36,5 @@ yarn.lock
/pnpm-lock.yaml

*.tgz

.node-version
25 changes: 25 additions & 0 deletions .vscode/cspell-windows-terms.dict
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
# Custom Dictionary Words
armv
asar
CODESIGN
deasync
dotenv
DOTENV
esmodule
felixrieseberg
flatpak
libv
Libv
linuxbrew
macintoshjs
nektos
pipefail
retrocomputers
retrocomputing
Rieseberg
shopt
softprops
TASKFILE
timheuer
yarnrc
ZKYDCJ
42 changes: 42 additions & 0 deletions .vscode/launch.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,48 @@
"runtimeArgs": [],
"cwd": "${workspaceFolder}",
"console": "integratedTerminal"
},
{
"type": "msedge",
"name": "Launch Microsoft Edge",
"request": "launch",
"runtimeArgs": ["--remote-debugging-port=9222"],
"url": " http://localhost:1313",
"presentation": {
"hidden": true
}
},
{
"type": "msedge",
"name": "Launch Microsoft Edge in headless mode",
"request": "launch",
"runtimeArgs": ["--headless", "--remote-debugging-port=9222"],
"url": " http://localhost:1313",
"presentation": {
"hidden": true
}
},
{
"type": "vscode-edge-devtools.debug",
"name": "Open Edge DevTools",
"request": "attach",
"url": " http://localhost:1313",
"presentation": {
"hidden": true
}
}
],
"compounds": [
{
"name": "Launch Edge Headless and attach DevTools",
"configurations": [
"Launch Microsoft Edge in headless mode",
"Open Edge DevTools"
]
},
{
"name": "Launch Edge and attach DevTools",
"configurations": ["Launch Microsoft Edge", "Open Edge DevTools"]
}
]
}
5 changes: 3 additions & 2 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,8 @@
],
"typescript.reportStyleChecksAsWarnings": false,
"typescript.surveys.enabled": false,
"typescript.tsc.autoDetect": "build",
"typescript.tsc.autoDetect": "watch",
"typescript.tsdk": "node_modules/typescript/lib",
"typescript.tsserver.web.projectWideIntellisense.enabled": true
"typescript.tsserver.web.projectWideIntellisense.enabled": true,
"livePreview.defaultPreviewPath": "/dist/index.html"
}
11 changes: 11 additions & 0 deletions cspell.config.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
version: '0.2'
ignorePaths: []
dictionaryDefinitions:
- name: windows-terms
path: ./.vscode/cspell-windows-terms.dict
addWords: true
dictionaries:
- windows-terms
words: []
ignoreWords: []
import: []
7 changes: 5 additions & 2 deletions eslint.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,12 @@

const globals = require('globals')
const tsPlugin = require('@typescript-eslint/eslint-plugin')

// @ts-ignore
const tsEslint = require('typescript-eslint')

const eslintPluginPrettier = require('eslint-plugin-prettier')

// @ts-ignore
const react = require('eslint-plugin-react/configs/recommended')

Expand All @@ -20,7 +23,7 @@ module.exports = [
// https://github.com/jsx-eslint/eslint-plugin-react#configuration
{
files: ['src/**/*.{ts,tsx}'],
ignores: ['dist/**/*.js'],
ignores: ['dist/emulator.*.js', 'dist/index.*.js'],
settings: {
react: {
version: 'detect'
Expand All @@ -42,7 +45,7 @@ module.exports = [
},
ecmaVersion: 2022,
project: true,
tsconfigRootDir: __dirname // or import.meta.dirname for ESM
tsconfigRootDir: __dirname
},
globals: { ...globals.browser, ...globals.es2024 }
},
Expand Down
8 changes: 2 additions & 6 deletions forge.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ const package_json = require('./package.json')

require('dotenv').config()

/* @joelvaneenwyk #todo
if (process.env['WINDOWS_CODESIGN_FILE']) {
const certPath = path.join(__dirname, 'win-certificate.pfx')
const certExists = fs.existsSync(certPath)
Expand All @@ -12,6 +13,7 @@ if (process.env['WINDOWS_CODESIGN_FILE']) {
process.env['WINDOWS_CODESIGN_FILE'] = certPath
}
}
*/

module.exports = {
hooks: {
Expand Down Expand Up @@ -84,12 +86,6 @@ module.exports = {
certificatePassword: process.env['WINDOWS_CODESIGN_PASSWORD']
}
}
},
{
name: '@electron-forge/maker-deb'
},
{
name: '@electron-forge/maker-rpm'
}
],
plugins: [
Expand Down
Loading
Loading