Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[c#] support setter assignments whose lhs is an identifier #5296

Merged
merged 1 commit into from
Feb 6, 2025
Merged

[c#] support setter assignments whose lhs is an identifier #5296

merged 1 commit into from
Feb 6, 2025

Conversation

xavierpinho
Copy link
Contributor

Supporting, e.g. x = 0 and x += 1 when x denotes a setter property, lowering them as set_X(0) and set_X(get_X() + 1), respectively. Previously, this lowering only applied when the LHS was a member access, like this.x or SomeClass.x.

@xavierpinho xavierpinho added the c# Relates to csharpsrc2cpg label Feb 6, 2025
@xavierpinho xavierpinho merged commit 91f08be into master Feb 6, 2025
5 checks passed
@xavierpinho xavierpinho deleted the xavierp/c#-setter-lhs-identifier branch February 6, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidBakerEffendi DavidBakerEffendi DavidBakerEffendi approved these changes

@max-leuthaeuser max-leuthaeuser Awaiting requested review from max-leuthaeuser

Assignees
No one assigned
Labels
c# Relates to csharpsrc2cpg
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xavierpinho @DavidBakerEffendi