Finishing up admin settings page work #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ignore formatting for now... VSCode always messes with it. |
|
Formatting of the code aside, all values on the settings form should work. They ugly, but they work. |
mikeethedude
commented
Jan 8, 2022
| @@ -19,12 +19,11 @@ | |||
| const childInputs = newRow.getElementsByTagName('input'); | |||
| for (let i = 0; i < childInputs.length; i++) { | |||
| childInputs[i].value = ""; | |||
| childInputs[i].name = childInputs[i].name.replace(/(\d+)/, rowCount); | |||
| childInputs[i].name = childInputs[i].name.replace(/\d+(?!.*\d+)/, rowCount); | |||
There was a problem hiding this comment.
This is a negative look ahead so we can always get the last value.
mikeethedude
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The settings page still needs a lot of work to be functional. This will get us closer than ever.
You may want to clear your database or start over if you haven't loaded this in a while.
Testing