Fix minor message formatting #1395
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The message() function doesn't add spaces between strings. So this commit corrects the message from printing out "samples removedbecause" to "samples removed because".
This commit fixes the message output so that there is a space between the number of OTUs removed and the string. So this commit fixes an example message such as "123OTUs were removed" to "123 OTUs were removed".
The `sep` argument is used to separate strings that are being pasted together. The pasted input here is merely a vector of strings that won't be pasted together. So the message output currently pastes them all together like "SAMPLE1SAMPLE2SAMPLE3". This commit replaces the sep argument with the collapse argument, which will change this behavior to add tabs between the sample names that are removed.
erictleung
commented
Sep 29, 2020
| @@ -183,7 +183,8 @@ rarefy_even_depth <- function(physeq, sample.size=min(sample_sums(physeq)), | |||
| rmtaxa = taxa_names(newsub)[taxa_sums(newsub) <= 0] | |||
| if( length(rmtaxa) > 0 ){ | |||
| if(verbose){ | |||
| message(length(rmtaxa), "OTUs were removed because they are no longer \n", | |||
| message(length(rmtaxa), | |||
| " OTUs were removed because they are no longer \n", | |||
There was a problem hiding this comment.
Related PR #875
I can rebase my PR if the above PR gets merged.
colinbrislawn
approved these changes
Jul 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.