did a tiny bit of code cleanup, encountered a bug that might fix some sleep-mode issues #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g through the index each time, and also recalculate can_sleep based on the timeout loop call.
|
Looks good to me. Slightly dubious about the last commit in the stack but that seems like personal preference as much as anything, so I'm fine with merging it as-is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while renaming the
current_watch_faceandnext_watch_faceto be clear that they are indexes into thewatch_facearray, we updated the app loop to use a pointer to the current face. This made us realize that the face loop can be visited twice in one turn, and thus cause conflict incan_sleep. This is resolved by boolean-ANDing the previous result in.