Add Chirpy support to databank #479
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanoskarsson
commented
Sep 28, 2024
| @@ -40,12 +41,99 @@ const char *pi_data[] = { | |||
|
|
|||
| const int databank_num_pages = (sizeof(pi_data) / sizeof(char*) / 2); | |||
|
|
|||
| typedef enum { | |||
| DATABANK_DISPLAY = 0, | |||
| DATABANK_CHIRPING, | |||
There was a problem hiding this comment.
The chirping mode changes the ticks to speed up etc.
johanoskarsson
commented
Sep 28, 2024
| } | ||
|
|
||
| // Which byte are we currently processing? | ||
| static uint16_t curr_data_ix; |
There was a problem hiding this comment.
In the chirpy demo code we also have data length and pointer to data here. But I'm instead using just whatever the currently displayed data is.
johanoskarsson
commented
Sep 28, 2024
|
|
||
| static uint8_t _databank_get_next_byte(uint8_t *next_byte) { | ||
| // We always send out the currently displayed dataset | ||
| int curr_pos = databank_state.databank_page * 2 + 1; |
There was a problem hiding this comment.
I'll be honest I don't quite understand the pagination used into the pi_data array, but this seems to work.
johanoskarsson
commented
Sep 28, 2024
| break; | ||
| case EVENT_LIGHT_BUTTON_UP: | ||
| databank_state.current_word = (databank_state.current_word + max_words - 1) % max_words; | ||
| // TODO ideally change this to chirp if both buttons are pressed at the same time? |
There was a problem hiding this comment.
This is what I mentioned in the PR description. This shouldn't be in this section, but I'm not sure what the best practices is to trigger the chirping since all button presses are used already.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just backed the Sensor Watch Pro campagin, so I figured I'd check out the code a bit. This PR adds Chirp support to the databank to get the data back out of the watch again.
I closely followed the chirpy demo code. More comments inline.
However: one issue remains. Since the light and alarm buttons are already used in both short press and long press I'm not sure what I should be using to trigger the chirping. One idea was simultaneous presses of the light and alarm buttons? I notice there is no specific event for this. I could probably work around that but I figured I'd ask for advice.