Create a new set of "hidden" watch faces. #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These watch faces are defined after the "secondary" ones but are skipped in normal Mode operation. Instead, the intention is to have another watch face jump directly there, typically this can be used by the clock_face to jump to the set_time_face when Alarm is long pressed. As is done here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This creates a new set of "hidden" watch faces, defined after the "secondary" ones but that are skipped in normal Mode operation.
Why
The intention is to have another watch face jump directly to the "hidden" face. Typically this can be used by the clock_face to jump to the set_time_face when Alarm is long pressed. As is done here.
This would allow to remove one watch face from the secondary cycle, making it easier to navigate in the presence of many other faces. It is common on casio watches (although not the f91 one) to set the time by long pressing a button on the main clock screen.
Context
At this stage this PR is mostly here to gather comment. I think that it would work better once #84 is merged, so that there is still a way to set the hourly chime. In addition, the submitted version might set
MOVEMENT_HIDDEN_FACE_INDEXto 0 by default to keep the current behavior. That being said, after #84 I think that it makes more sense to set the time using a long press to Alarm than to set the 12/24 mode, as any given user will probably never change the latter. So a quick access to the set_time_face makes more sense to me.