Bugfix: Titles with accents (example: Spanish) was not working #393
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Markdown titles that contains accents (example: in Spanish) has an encoded
location.hash
.To make the scrollDown working in that cases, you need to use
decodeURIComponent
, in the other case the element will not be found and scrollDown will not occur.An example with the title "Configuración" ("Configuration" in Spanish)
Configuración
But the element ID has the accent without the encoding: