Using slf4j-api and not logback-classic in several modules that accid…

…entally brought logback in a compile dependency
johanhaleby · Feb 9, 2024 · 7d6cbec · 7d6cbec
1 parent 015c122
commit 7d6cbec
Show file tree

Hide file tree

Showing 4 changed files with 32 additions and 10 deletions.
diff --git a/changelog.md b/changelog.md
@@ -6,7 +6,8 @@
 
   // GameStarted has GameEvent as parent, the following didn't compile in version 0.17.0 
   subscriptions.subscribe("ikk", GameStarted.class, gameStarted -> System.out.println("gameStarted: " + gameStarted));
-  ```                                                                                 
+  ```
+* Using slf4j-api and not logback-classic in seUsing slf4j-api and not logback-classic in several modules that accidentally brought logback in a compile dependencyveral modules that accidentally brought logback in a compile dependency.                                                                                 
 * Upgraded slf4j-api from 2.0.5 to 2.0.12
 
 ### 0.17.0 (2024-01-19)

diff --git a/subscription/mongodb/common/blocking/competing-consumer-strategy/pom.xml b/subscription/mongodb/common/blocking/competing-consumer-strategy/pom.xml
@@ -1,5 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
     <parent>
         <artifactId>subscription-mongodb-common-blocking</artifactId>
         <groupId>org.occurrent</groupId>
@@ -30,10 +31,11 @@
             <version>0.17.1-SNAPSHOT</version>
         </dependency>
         <dependency>
-            <groupId>ch.qos.logback</groupId>
-            <artifactId>logback-classic</artifactId>
+            <groupId>org.slf4j</groupId>
+            <artifactId>slf4j-api</artifactId>
         </dependency>
 
+
         <!-- Test -->
         <dependency>
             <groupId>org.occurrent</groupId>
@@ -63,6 +65,11 @@
             <artifactId>awaitility</artifactId>
             <scope>test</scope>
         </dependency>
+        <dependency>
+            <groupId>ch.qos.logback</groupId>
+            <artifactId>logback-classic</artifactId>
+            <scope>test</scope>
+        </dependency>
     </dependencies>
 
 </project>
diff --git a/subscription/util/blocking/competing-consumer-subscription/pom.xml b/subscription/util/blocking/competing-consumer-subscription/pom.xml
@@ -1,5 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
     <parent>
         <artifactId>subscription-util-blocking</artifactId>
         <groupId>org.occurrent</groupId>
@@ -25,10 +26,11 @@
             <artifactId>jakarta.annotation-api</artifactId>
         </dependency>
         <dependency>
-            <groupId>ch.qos.logback</groupId>
-            <artifactId>logback-classic</artifactId>
+            <groupId>org.slf4j</groupId>
+            <artifactId>slf4j-api</artifactId>
         </dependency>
 
+
         <!-- Test -->
         <dependency>
             <groupId>org.occurrent</groupId>
@@ -101,6 +103,11 @@
             <artifactId>junit-jupiter-engine</artifactId>
             <scope>test</scope>
         </dependency>
+        <dependency>
+            <groupId>ch.qos.logback</groupId>
+            <artifactId>logback-classic</artifactId>
+            <scope>test</scope>
+        </dependency>
     </dependencies>
 
 

diff --git a/subscription/util/reactor/durable-subscription/pom.xml b/subscription/util/reactor/durable-subscription/pom.xml
@@ -15,7 +15,8 @@
   ~ limitations under the License.
   -->
 
-<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
     <parent>
         <artifactId>subscription-util-reactor</artifactId>
         <groupId>org.occurrent</groupId>
@@ -37,10 +38,11 @@
             <version>0.17.1-SNAPSHOT</version>
         </dependency>
         <dependency>
-            <groupId>ch.qos.logback</groupId>
-            <artifactId>logback-classic</artifactId>
+            <groupId>org.slf4j</groupId>
+            <artifactId>slf4j-api</artifactId>
         </dependency>
 
+
         <!-- Test -->
         <dependency>
             <groupId>org.occurrent</groupId>
@@ -112,5 +114,10 @@
             <artifactId>rerunner-jupiter</artifactId>
             <scope>test</scope>
         </dependency>
+        <dependency>
+            <groupId>ch.qos.logback</groupId>
+            <artifactId>logback-classic</artifactId>
+            <scope>test</scope>
+        </dependency>
     </dependencies>
 </project>