Refactor and improve component API with f32 infinities #62
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thanks for the library! I wanted to improve its code quality, so I've decided to open this PR. Here's what I've done:
Rect
,Aabb2d
and Rust'sRange
types to make the code more idiomatic;f32::INFINITY
andf32::NEG_INFINITY
, making calculations seamless and simpler (as opposed to constantly dealing withOption
s);vec2
overVec2::new
(previously, the code contained both);single
toget_single
incamera_zoom
(similar to what use get_single when getting the window #58 did forcamera_movement
);Sorry if this turned out too opinionated. Feel free to discuss any points in the PR :)