Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose WebAssetReader as part of the public API #21

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Expose WebAssetReader as part of the public API #21

merged 1 commit into from
Nov 28, 2023

Conversation

oli-obk
Copy link

@oli-obk oli-obk commented Nov 25, 2023

I would like to reuse the implementation of this crate, but do two things:

  • write my own wrapper AssetReader around it (hardcoded base url and some other shenanigans)
  • use it as a default AssetReader

Exposing the web asset reader publicly will achieve this, as I can then use the AssetReader impl (which is public by definition) and invoke it from my own AssetReader impl

johanhelsing
johanhelsing approved these changes Nov 28, 2023
View reviewed changes
Copy link
Owner

@johanhelsing johanhelsing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Makes sense.

@johanhelsing johanhelsing merged commit d31ac01 into johanhelsing:main Nov 28, 2023
3 checks passed
@oli-obk oli-obk deleted the public branch November 28, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanhelsing johanhelsing johanhelsing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oli-obk @johanhelsing