PR dealing with Issue #359 (Beta) #400
Conversation
Remove duplicate line in example grott.ini, fix comment
Thx @Maes152 for reporting. - Added unit tests
- added unit tests
- Fixed some UT
|
@KevinEeckman I am not sure what is happening but for me it looks like your not applying the changes to the Grott Hub beta branch. By example in the grottdata.py do not recognize coding like (line 83). TODO : this test is a too arbitrary. We just assume that no Growatt inverter can handle more than 12000W of input solar power.I really do not know what happens if I commit this PR. I see also a couple of changes by the groot_ha.py extension but that is already verified by @egguy so I suppose that will be ok. |
|
I'm no Git expert and the commits indeed look weird, but if you compare your Beta branch and this PR, there should be only my changes. The code you don't recognize is somthing I added after, on my inverter I sometime receive packets which make no sense (like 5MW of PV production), and I am filtering them out using the piece of code above. I did not include them in my previous PR because it was on master, but since this is beta I thought it would be ok. There are unit tests for that. Did you also publish your test program, so that I can see if I can bring it under the unit test framework, to simplify future merges ? |
Copied modified extension from 2,.7.8
add invFanSpeed to SPF layout
added invfanspeed to SPF layout
Added T06NNNNXMOD layout file to examples Copy this in base Grott directory Specify invtype = mod in grott.in Restart Grott
change default growatt IP address to server.growatt.com URL, hopefully this will prevent growatt from changing IP address and the need for changing IP address in grott.ini
New pull request for Issue #359, now on top of the Beta branch