Fix parent transaction linking, add more details to transactions and update to newest Sentry SDK #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a project where we use this library the span created by the server interceptor was not correctly linked to the parent span from the client. Also requests with no trace id would not get there spans registered, since Sentry will throw away any spans that do not have a transaction. We were also missing some details about the transaction, like the grpc method that was used.
Here is a list of the changes:
StartTransaction
instead ofStartSpan
. This will ensure the span to be registered in Sentry.sentry-trace
header, also add thebaggage
header to grpc requests. This is used for distributed Sentry tracing.0.27.0
.Sampled
value of a transaction totrue
when an error occurs, so all errors will contain traces.