Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parent transaction linking, add more details to transactions and update to newest Sentry SDK #21

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

janwytze
Copy link
Contributor

In a project where we use this library the span created by the server interceptor was not correctly linked to the parent span from the client. Also requests with no trace id would not get there spans registered, since Sentry will throw away any spans that do not have a transaction. We were also missing some details about the transaction, like the grpc method that was used.

Here is a list of the changes:

  • Use StartTransaction instead of StartSpan. This will ensure the span to be registered in Sentry.
  • Beside the sentry-trace header, also add the baggage header to grpc requests. This is used for distributed Sentry tracing.
  • Update to Sentry SDK 0.27.0.
  • Set the Sampled value of a transaction to true when an error occurs, so all errors will contain traces.

@johnbellone johnbellone merged commit da363e7 into johnbellone:master Apr 19, 2024
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants