Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mouse button history #1474

Open
wants to merge 2 commits into
base: gtk4
Choose a base branch
from
Open

mouse button history #1474

wants to merge 2 commits into from

Conversation

mullet-dev
Copy link

Maps mouse forward/backward buttons to reader.view.history.

Reference:

@@ -261,6 +261,18 @@
},
}))

// Mouse Forward/Backward

Check warning

Code scanning / ESLint

Enforce consistent indentation Warning

Expected indentation of 8 spaces but found 1 tab.
@@ -261,6 +261,18 @@
},
}))

// Mouse Forward/Backward
const gestureForward = new Gtk.GestureClick()

Check warning

Code scanning / ESLint

Enforce consistent indentation Warning

Expected indentation of 8 spaces but found 1 tab.
@@ -261,6 +261,18 @@
},
}))

// Mouse Forward/Backward
const gestureForward = new Gtk.GestureClick()
const gestureBack = new Gtk.GestureClick()

Check warning

Code scanning / ESLint

Enforce consistent indentation Warning

Expected indentation of 8 spaces but found 1 tab.
// Mouse Forward/Backward
const gestureForward = new Gtk.GestureClick()
const gestureBack = new Gtk.GestureClick()
gestureForward.set_button(9)

Check warning

Code scanning / ESLint

Enforce consistent indentation Warning

Expected indentation of 8 spaces but found 1 tab.
const gestureForward = new Gtk.GestureClick()
const gestureBack = new Gtk.GestureClick()
gestureForward.set_button(9)
gestureBack.set_button(8)

Check warning

Code scanning / ESLint

Enforce consistent indentation Warning

Expected indentation of 8 spaces but found 1 tab.
gestureBack.set_button(8)
this.#webView.add_controller(utils.connect(gestureForward,{
"pressed": () => this.#exec('reader.view.history.forward')
}))

Check warning

Code scanning / ESLint

Enforce consistent indentation Warning

Expected indentation of 8 spaces but found 1 tab.
this.#webView.add_controller(utils.connect(gestureForward,{
"pressed": () => this.#exec('reader.view.history.forward')
}))
this.#webView.add_controller(utils.connect(gestureBack,{

Check warning

Code scanning / ESLint

Enforce consistent indentation Warning

Expected indentation of 8 spaces but found 1 tab.
"pressed": () => this.#exec('reader.view.history.forward')
}))
this.#webView.add_controller(utils.connect(gestureBack,{
"pressed": () => this.#exec('reader.view.history.back')

Check warning

Code scanning / ESLint

Enforce the consistent use of either backticks, double, or single quotes Warning

Strings must use singlequote.
Comment on lines 273 to 274
"pressed": () => this.#exec('reader.view.history.back')
}))

Check warning

Code scanning / ESLint

Require or disallow trailing commas Warning

Missing trailing comma.
}))
this.#webView.add_controller(utils.connect(gestureBack,{
"pressed": () => this.#exec('reader.view.history.back')
}))

Check warning

Code scanning / ESLint

Enforce consistent indentation Warning

Expected indentation of 8 spaces but found 1 tab.
@johnfactotum
Copy link
Owner

Can you fix the formatting warning? You fix them by running npx eslint --fix.

@mullet-dev
Copy link
Author

Can you fix the formatting warning? You fix them by running npx eslint --fix.

Fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants