Skip to content

Commit

Permalink
Wrapper : Reintroduce LC_NUMERIC=C
Browse files Browse the repository at this point in the history
I removed this in e323014 after verifying that the OCIO bug it worked around was now fixed properly. But what I didn't realise is that we have our _own_ equivalent bug in ImageEngine/cortex#1338. So I'm reverting the change until we have time to fix properly in Cortex.

Fixes GafferHQ#5158
  • Loading branch information
johnhaddon committed Feb 24, 2023
1 parent 84733df commit 08acbfa
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 0 deletions.
7 changes: 7 additions & 0 deletions Changes.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,13 @@
1.2.x.x (relative to 1.2.0.2)
=======

Fixes
-----

- Locale :
- Reintroduced `LC_NUMERIC=C` environment variable assignment to wrapper. This was removed in `1.2.0.0` but is still necessary due to a [bug in Cortex](https://github.com/ImageEngine/cortex/issues/1338).
- Fixed serialisation of `.gfr` files in locales with non-default numeric formatting (#5158).

Documentation
-------------

Expand Down
6 changes: 6 additions & 0 deletions bin/gaffer
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,12 @@ if [[ $1 == -psn_0_* ]] ; then
shift
fi

# Work around https://github.com/ImageEngine/cortex/issues/1338, which
# causes bad serialisations in certain locales.
##########################################################################

export LC_NUMERIC=C

# Find where this script is located, resolving any symlinks that were used
# to invoke it. Set GAFFER_ROOT based on the script location.
##########################################################################
Expand Down

0 comments on commit 08acbfa

Please sign in to comment.