Fix #1462: remove limit of 1000 on dedupe field names (#1463)

* Fix #1462: remove limit of 1000 on dedupe field names * make dev output
johnkerl · Jan 1, 2024 · 2f42c6f · 2f42c6f
1 parent e3b98cd
commit 2f42c6f
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 7 deletions.
diff --git a/docs/src/manpage.md b/docs/src/manpage.md
@@ -3689,5 +3689,5 @@ MILLER(1)                                                            MILLER(1)
 
 
 
-                                  2023-12-23                         MILLER(1)
+                                  2024-01-01                         MILLER(1)
 </pre>
diff --git a/docs/src/manpage.txt b/docs/src/manpage.txt
@@ -3668,4 +3668,4 @@ MILLER(1)                                                            MILLER(1)
 
 
 
-                                  2023-12-23                         MILLER(1)
+                                  2024-01-01                         MILLER(1)
diff --git a/man/manpage.txt b/man/manpage.txt
@@ -3668,4 +3668,4 @@ MILLER(1)                                                            MILLER(1)
 
 
 
-                                  2023-12-23                         MILLER(1)
+                                  2024-01-01                         MILLER(1)
diff --git a/man/mlr.1 b/man/mlr.1
@@ -2,12 +2,12 @@
 .\"     Title: mlr
 .\"    Author: [see the "AUTHOR" section]
 .\" Generator: ./mkman.rb
-.\"      Date: 2023-12-23
+.\"      Date: 2024-01-01
 .\"    Manual: \ \&
 .\"    Source: \ \&
 .\"  Language: English
 .\"
-.TH "MILLER" "1" "2023-12-23" "\ \&" "\ \&"
+.TH "MILLER" "1" "2024-01-01" "\ \&" "\ \&"
 .\" -----------------------------------------------------------------
 .\" * Portability definitions
 .\" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

diff --git a/pkg/mlrval/mlrmap_accessors.go b/pkg/mlrval/mlrmap_accessors.go
@@ -74,15 +74,14 @@ func (mlrmap *Mlrmap) PutReferenceMaybeDedupe(key string, value *Mlrval, dedupe
 		return key, nil
 	}
 
-	for i := 2; i < 1000; i++ {
+	for i := 2; ; i++ {
 		newKey := key + "_" + strconv.Itoa(i)
 		pe := mlrmap.findEntry(newKey)
 		if pe == nil {
 			mlrmap.putReferenceNewAux(newKey, value)
 			return newKey, nil
 		}
 	}
-	return key, fmt.Errorf("record has too many input fields named \"%s\"", key)
 }
 
 // PutCopy copies the key and value (deep-copying in case the value is array/map).
Original file line number	Diff line number	Diff line change
Expand Up		@@ -3689,5 +3689,5 @@ MILLER(1) MILLER(1)



		2023-12-23 MILLER(1)
		2024-01-01 MILLER(1)
		</pre>
Original file line number	Diff line number	Diff line change
Expand Up		@@ -3668,4 +3668,4 @@ MILLER(1) MILLER(1)



		2023-12-23 MILLER(1)
		2024-01-01 MILLER(1)