test: add a test for newVersion

johnmanjiro13 · Jun 5, 2022 · fbd69a2 · fbd69a2
1 parent 39e3818
commit fbd69a2
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 3 deletions.
diff --git a/bump/bumper.go b/bump/bumper.go
@@ -156,7 +156,7 @@ func (b *bumper) currentVersion() (*semver.Version, bool, error) {
 	sout, eout, err := b.gh.ViewRelease(b.repository, b.isCurrent)
 	if err != nil {
 		if strings.Contains(eout.String(), "HTTP 404: Not Found") {
-			current, err := newVersion()
+			current, err := newVersion(os.Stdin, os.Stdout)
 			if err != nil {
 				return nil, isInitial, err
 			}
@@ -174,7 +174,7 @@ func (b *bumper) currentVersion() (*semver.Version, bool, error) {
 	return current, isInitial, nil
 }
 
-func newVersion() (*semver.Version, error) {
+func newVersion(sin io.ReadCloser, sout io.WriteCloser) (*semver.Version, error) {
 	validate := func(input string) error {
 		_, err := semver.NewVersion(input)
 		if err != nil {
@@ -186,6 +186,8 @@ func newVersion() (*semver.Version, error) {
 	prompt := promptui.Prompt{
 		Label:    "New version",
 		Validate: validate,
+		Stdin:    sin,
+		Stdout:   sout,
 	}
 	result, err := prompt.Run()
 	if err != nil {

diff --git a/bump/bumper_test.go b/bump/bumper_test.go
@@ -202,6 +202,14 @@ func (m *mockWriteCloser) Close() error {
 	return nil
 }
 
+func TestNewVersion(t *testing.T) {
+	sin := io.NopCloser(strings.NewReader("v0.1.0\n"))
+	sout := &mockWriteCloser{bytes.Buffer{}}
+	newVer, err := bump.NewVersion(sin, sout)
+	assert.NoError(t, err)
+	assert.Equal(t, semver.MustParse("v0.1.0"), newVer)
+}
+
 func TestNextVersion(t *testing.T) {
 	sin := io.NopCloser(strings.NewReader(string(arrowDownAndEnter)))
 	sout := &mockWriteCloser{bytes.Buffer{}}
@@ -252,6 +260,7 @@ func TestIncrementVersion(t *testing.T) {
 	tests := map[string]struct {
 		bumpType string
 		want     *semver.Version
+		wantErr  error
 	}{
 		"major": {
 			bumpType: "major",
@@ -265,12 +274,16 @@ func TestIncrementVersion(t *testing.T) {
 			bumpType: "patch",
 			want:     semver.MustParse("v0.1.1"),
 		},
+		"invalid": {
+			bumpType: "invalid",
+			wantErr:  fmt.Errorf("invalid type"),
+		},
 	}
 
 	for name, tt := range tests {
 		t.Run(name, func(t *testing.T) {
 			got, err := bump.IncrementVersion(current, tt.bumpType)
-			assert.NoError(t, err)
+			assert.Equal(t, tt.wantErr, err)
 			assert.Equal(t, tt.want, got)
 		})
 	}

diff --git a/bump/export_test.go b/bump/export_test.go
@@ -5,6 +5,7 @@ var (
 	ListReleases      = (*bumper).listReleases
 	CreateRelease     = (*bumper).createRelease
 	CurrentVersion    = (*bumper).currentVersion
+	NewVersion        = newVersion
 	NextVersion       = nextVersion
 	IncrementVersion  = incrementVersion
 	Approve           = approve