Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2 - Modification needed in xcunsign,xcrestore script for macOS Sierra #3

Merged
merged 1 commit into from
Oct 13, 2016
Merged

Conversation

kaustubhkabra
Copy link
Contributor

This commit will fix issue issue #2.

@johntmcintosh
Copy link
Owner

@kaustubh-kabra thanks for the PR! Can you confirm for me that you are able to run xcrestore after xcunsign and that it restores Xcode correctly on Sierra with this change?

If you have fastlane installed, the best test would be to run fastlane run verify_xcode 8.0 after unsigning and then restoring. If the verify passes successfully, we can be confident that the restore worked as intended.

@kaustubhkabra
Copy link
Contributor Author

I don't use Fastlane but I confirm restore is working fine after unsign -
screen shot 2016-10-13 at 8 07 01 pm

@johntmcintosh
Copy link
Owner

Awesome, thanks for the confirmation!

@johntmcintosh johntmcintosh merged commit 4d917ff into johntmcintosh:master Oct 13, 2016
@kaustubhkabra
Copy link
Contributor Author

Cheers !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants