-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revise configuration handling #305
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to feature/config
- remove identifier 'auxdata' and do not set is as config - remove config section 'OUTPUT' - do not set config 'auxdatapath', 'properties' - remove method `__update_snap_properties` and instead use SnapProperties class - new properties 'auxdatapath', 'userdir'
…to feature/config
…to feature/config
Pull Request Test Coverage Report for Build 9093547722Details
💛 - Coveralls |
…to feature/config
…rather raise an AttributeError when trying to access the attributes path or gpt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a long due revision of the configuration handling. Now, pyroSAR's configuration integrates much better with that of SNAP and a user can directly modify SNAP configuration via pyroSAR.
All changes in a nutshell:
_dev_config.py
toconfig.py
__LOCAL__
(indrivers.py
andconfig.py
) intoconfig.py
config.py
: removed classStorage
and its usesexamine.SnapProperties
for reading and modifying SNAP configurationexamine.ExamineSnap
:auxdata
fromidentifiers
and don't set it as attributeOUTPUT
auxdatapath
,properties
__update_snap_properties
and instead use newSnapProperties
class to set attributesnap_properties
auxdatapath
anduserpath
Example to modify the SNAP user directory to change the location where SNAP stores any data during processing:
This will add an entry
snap.userdir = /path/to/snap/data
in$HOME/.snap/etc/snap.properties
, which will then be read by SNAP and relevant pyroSAR functions like e.g. auxdata.dem_autoload.