Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Archive.select] do not accept multi-feature vectorobjects #316

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

johntruckenbrodt
Copy link
Owner

@johntruckenbrodt johntruckenbrodt commented Jul 22, 2024

...instead of just selecting the first feature for search. Before this, a user could get an unexpected result when passing an object with multiple features and expecting a search for all scenes overlapping with these features.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10055320343

Details

  • 3 of 4 (75.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 52.324%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pyroSAR/drivers.py 3 4 75.0%
Totals Coverage Status
Change from base Build 10055294065: 0.006%
Covered Lines: 3659
Relevant Lines: 6993

💛 - Coveralls

@johntruckenbrodt johntruckenbrodt merged commit 0ca33cb into main Jul 23, 2024
4 checks passed
@johntruckenbrodt johntruckenbrodt deleted the bugfix/archive_select_features branch July 23, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants