Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded prometheus to newest version #122

Merged

Conversation

Stephan3555
Copy link
Contributor

@Stephan3555 Stephan3555 commented May 14, 2023

Upgraded Prometheus to latest version.

Fixed unit tests as there is a new default metric called "_created". See: https://github.com/prometheus/client_java/releases/tag/parent-0.10.0

@Stephan3555
Copy link
Contributor Author

@johrstrom would be nice if you could review my PR. I ugraded the prometheus client to newest version 0.16.0 and fixed the tests accordingly.

@Stephan3555
Copy link
Contributor Author

@johrstrom any update? :-)

@johrstrom
Copy link
Owner

Sorry for the delay, I'll carve out some time tonight to sort this out.

@johrstrom johrstrom merged commit 4969b8e into johrstrom:main Jul 30, 2023
2 checks passed
@johrstrom
Copy link
Owner

Hey, I'm so sorry for the delay. I'll get this pushed out in a tag shortly. I just had to rebase for you. The tests changes through me off a bit so I had to look up the changes upstream.

Thanks for the contribution and again, sorry for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants