Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix undefined resolveType issue #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix undefined resolveType issue #11

wants to merge 1 commit into from

Conversation

adelsz
Copy link

@adelsz adelsz commented Aug 27, 2018 •
edited
Loading

Interface and union types resolveType resolution was broken.
GraphQLInterfaceType, GraphQLUnionType were missing the resolveType after joinMonsterAdapt. This happened because resolveType field should be set at type level and not in type._typeConfig.

@frederikhors
Copy link

@adelsz is this related to this? #12

@adelsz
Copy link
Author

adelsz commented Sep 6, 2018

@frederikhors I don't think so. type._typeConfig is defined in this case.

@lorensr
Copy link
Member

lorensr commented Jan 22, 2020

@adelsz is this still an issue in the 0.1.0 version I just published?

@lorensr
Copy link
Member

lorensr commented Jan 22, 2020

It includes these changes:

https://github.com/acarl005/join-monster-graphql-tools-adapter/pull/15/files

@adelsz
Copy link
Author

adelsz commented Jan 24, 2020

Unfortunately, I won't be able to check this any time soon.
But it shouldn't be too hard to check/reproduce with a mock GraphQLInterfaceType

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adelsz @frederikhors @lorensr