Skip to content

Commit

Permalink
Backwards support 6.1
Browse files Browse the repository at this point in the history
  • Loading branch information
David Kutalek authored and David Kutalek committed Aug 14, 2024
1 parent 94bfb58 commit efbf1c1
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 6 deletions.
4 changes: 2 additions & 2 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ PATH
remote: .
specs:
knockoff (1.4.0)
activerecord (~> 7.0.0)
activesupport (~> 7.0.0)
activerecord (>= 6.1, < 7.1)
activesupport (>= 6.1, < 7.1)

GEM
remote: https://rubygems.org/
Expand Down
4 changes: 2 additions & 2 deletions knockoff.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ Gem::Specification.new do |spec|
spec.bindir = "bin"
spec.require_paths = ["lib"]

spec.add_runtime_dependency 'activerecord', '~> 7.0.0'
spec.add_runtime_dependency 'activesupport', '~> 7.0.0'
spec.add_runtime_dependency 'activerecord', '>= 6.1', "< 7.1"
spec.add_runtime_dependency 'activesupport', '>= 6.1', "< 7.1"

spec.add_development_dependency "bundler"
spec.add_development_dependency "rake", "~> 10.0"
Expand Down
2 changes: 0 additions & 2 deletions lib/knockoff/replica_connection_pool.rb
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,6 @@ def connection_class(config_key)
# Config key is of schema 'knockoff_replica_n'
class_name = "KnockoffReplica#{config_key.split('_').last}"

puts "config_key: #{config_key} was something"

# TODO: Hardcoding the uri string feels meh. Either set the database config
# or reference ENV instead
Knockoff.module_eval %Q{
Expand Down

0 comments on commit efbf1c1

Please sign in to comment.