Refactor config to use rails 6.1 APIs #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
January 8, 2024 19:51
davkutalek
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DatabaseConfigurations is no longer a simple hash and the hash you can get from it is frozen rails/rails#33637
This updates the config so that it correctly manipulates the databaseconfiguration object by creating modifiable duplicates of the config hash.
The tests didn't catch this because if there are no configurations from Rails then it uses an empty hash. The tests are not trying to mock the response from rails, so they use the empty hash which is no longer the same. Ideally they should be updated.