Tests pass save for Previous Search and Three Day Forecast #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Angiepmunoz
reviewed
Jan 13, 2023
| // | ||
|
|
||
| function currentWeather(weatherData, city) { | ||
| let area = weatherData.nearest_area[0].areaName[0].value; |
There was a problem hiding this comment.
You need to remove the "Choose a location to view the weather" instead of hiding it
|
|
||
| let currently = weatherData.current_condition[0].FeelsLikeF; | ||
| let currentlyP = document.createElement('p'); | ||
| currentlyP.textContent = `Feels like it's ${currently}°F.`; |
There was a problem hiding this comment.
This string is different from what the tests and examples expect/show
| // | ||
| // | ||
| // | ||
|
|
There was a problem hiding this comment.
At the moment, every time a search is made the new location is added to the page instead of replacing the previous search. See image
There are a few ways to handle this. You can have a conditional that checks whether that code was already created an needs to be updated or if it wasn't create it - you create it.
Or you can delete the whole section and create it every time a search is made.
Those are just two ways to do it. I am sure there are more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will return to update CSS.