9.3 Weather App Project #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ml. moved Selectors outside of API Fetch to avoid duplicating elements
…e <li> elements. Added hidden attribute to conversion widget temporarily until JS Functionality is added. Elements with temperature values also now contain a ° (degree) symbol.
…e file added for list marker.
Angiepmunoz
reviewed
Jan 11, 2023
| <!--Contains current weather--> | ||
| <section class="current"> | ||
| <p class="empty">Choose a location to view the weather</p> | ||
| <article class="current" hidden />Current Forecast<br> |
There was a problem hiding this comment.
i believe this hidden element is contributing to you failing some of the tests. I'm not sure what the original intent was here but if it's not necessary it might be worth removing.
also the article tag needs a closing tag. <article /> doesn't work with this element.
Angiepmunoz
reviewed
Jan 11, 2023
| <article class="tomorrow" id="tomorrow"><strong class="headings">Tomorrow</strong></article> | ||
| <article class="day-after-tm" id="day-after-tm"><strong class="headings">Day After Tomorrow</strong></article> | ||
| </div> | ||
| </article> |
There was a problem hiding this comment.
I am unsure where the opening tag is for this closing aside tag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By no means do I consider this project finished– I've struggled so much with trying to removing duplicate list items, and the conversion widget is currently unavailable. However, I'm coming back to this project very soon to ensure that it not only passes all tests, but that it's fully functional, once my portfolio project is complete.
But if I can get this much done in a week after 3-ish months of coding, I'm excited for what I'll be able to do 3 more months from now!