diandre's pull request #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Angiepmunoz
commented
Jan 11, 2023
| console.log(request); | ||
|
|
||
|
|
||
| const weatherData = { |
There was a problem hiding this comment.
i would recommend putting something like this is a different file
Angiepmunoz
commented
Jan 11, 2023
| } | ||
| displayChanceOfSnow(); | ||
|
|
||
| //Function to display chance of thunder to the main section |
There was a problem hiding this comment.
Make sure to delete non-useable code before submitting
Angiepmunoz
commented
Jan 11, 2023
|
|
||
|
|
||
| //Display region to the main section | ||
| function displayRegion() { |
There was a problem hiding this comment.
functions like the this one and a few of the ones below can be all one function. There's no added benefit to having multiple functions that execute almost the same thing
Angiepmunoz
commented
Jan 11, 2023
|
|
||
|
|
||
| //Function to display weather gif over 50% chance | ||
| function displayWeatherGif() { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.