Switch to Github Actions #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
welcoMattic
approved these changes
Sep 10, 2021
Korbeil
force-pushed
the
feature/use-github-actions
branch
from
a6ee485 to
e5fa05b
Compare
lyrixx
reviewed
Sep 10, 2021
| @@ -0,0 +1,52 @@ | |||
| name: CI | |||
| on: [push, pull_request] | |||
There was a problem hiding this comment.
- Could you add a cron too, like https://github.com/jolicode/docker-starter/blob/main/.github/workflows/ci.yml#L8-L10
- we will only build push on master and pr: https://github.com/jolicode/docker-starter/blob/main/.github/workflows/ci.yml#L4-L7
(I contribute to this lib via this repo and not my fork. So there is no need to trigger the workflow twice)
| tests: | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| max-parallel: 15 |
Comment on lines
+14
to
+18
| - name: cache-composer | ||
| uses: actions/cache@v2 | ||
| with: | ||
| path: ~/.composer/cache/ | ||
| key: composer-${{ matrix.php-versions }}-${{ github.sha }} |
| name: tests-${{ matrix.php-versions }} | ||
| steps: | ||
| - name: checkout | ||
| uses: actions/checkout@master |
There was a problem hiding this comment.
This is fragile
Suggested change
| uses: actions/checkout@master | |
| uses: actions/checkout@v2 |
Comment on lines
+36
to
+40
| - name: cache-composer-lowest | ||
| uses: actions/cache@v2 | ||
| with: | ||
| path: ~/.composer/cache/ | ||
| key: composer-lowest-${{ github.sha }} |
| run: docker run -d -p 8081:80 httpbin | ||
| - name: tests | ||
| run: composer test | ||
| tests-lowest: |
There was a problem hiding this comment.
Can it be "merged" with the main job?
see https://github.com/jolicode/JoliNotif/blob/main/.github/workflows/ci.yml#L23-L35 for an example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.