Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add source argument to Handler for compatibility with Rails 6+ #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mrpinsky
Copy link

@mrpinsky mrpinsky commented Aug 3, 2020

Rails 6 now has a deprecation warning that single-arity templates will not be supported in the future. The separate, additional argument is the source of the template so that template compilers can treat the template object's source as immutable.

cf. rails/rails#35119

@mrpinsky
Copy link
Author

mrpinsky commented Aug 5, 2020

@joliss Does this look okay to you?

@mrpinsky
Copy link
Author

Bump @joliss

@armiiller
Copy link

Anything on this @joliss ? I've started installing this gem via @mrpinsky 's repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants